Add default generators #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-M-Lee
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Very nice! Small comment: I think people unfamiliar with statistical DoE might be confused by our use of the name "default generators". Especially since generators are of course also a python thing with a completely different meaning.
Fractional factorial designs are mentioned in the comment at the top of default_generators.py, but that's all. And it's in utils so the import also doesn't give you a clue about it's meaning. What do you think about slighly more verbose or different naming? Like default_FF_generators, default_fracfac_generators or something like that?
|
@R-M-Lee: thanks for the suggestion. I like it and implemented it. Best, Johannes |
R-M-Lee
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds default generators which are used for setting up for fractional factorial designs, which circumvents to compute them over and over agains. Furthermore some of them are better than the one which are provided by the current algorithm.